Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add l2 signed message support in inboxTools #194

Merged
merged 31 commits into from
Nov 4, 2022
Merged

chore: add l2 signed message support in inboxTools #194

merged 31 commits into from
Nov 4, 2022

Conversation

Jason-Wanxt
Copy link
Contributor

No description provided.

@cla-bot cla-bot bot added the cla-signed label Sep 21, 2022
yahgwai
yahgwai reviewed Sep 22, 2022
View reviewed changes
Copy link
Contributor

@yahgwai yahgwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the sdk job is failing because of formatting. You can run yarn format on your local repo to do the linting.

src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
integration_test/sendL2msg.test.ts Outdated Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
integration_test/sendL2msg.test.ts Outdated Show resolved Hide resolved
@Jason-Wanxt Jason-Wanxt requested a review from yahgwai September 27, 2022 09:40
yahgwai
yahgwai approved these changes Oct 20, 2022
View reviewed changes
src/lib/inbox/inbox.ts Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
integration_test/sendL2msg.test.ts Outdated Show resolved Hide resolved
integration_test/sendL2msg.test.ts Outdated Show resolved Hide resolved
@yahgwai yahgwai self-requested a review October 20, 2022 12:22
yahgwai
yahgwai reviewed Oct 20, 2022
View reviewed changes
Copy link
Contributor

@yahgwai yahgwai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor changes

@Jason-Wanxt Jason-Wanxt requested a review from yahgwai October 25, 2022 06:35
yahgwai
yahgwai reviewed Nov 2, 2022
View reviewed changes
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
src/lib/inbox/inbox.ts Outdated Show resolved Hide resolved
@Jason-Wanxt Jason-Wanxt requested review from yahgwai and removed request for fredlacs November 3, 2022 09:47
@yahgwai yahgwai changed the base branch from c-nitro-next to main November 4, 2022 08:47
@Jason-Wanxt Jason-Wanxt merged commit 098ff66 into main Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahgwai yahgwai yahgwai approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jason-Wanxt @yahgwai @Jason-W123