-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add function to obtain eth bridge contracts #260
Conversation
so I think the only thing you might want to add here is |
Changed logic so only the EthBridge information is retrieved from now. |
* of Arbitrum One network (42161) | ||
*/ | ||
describe('Obtain deployed bridge addresses', () => { | ||
it('obtains deployed ETH Bridge addresses', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move this test to integration tests since we're actually hitting the network and we're not mocking anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test moved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
First attempt to add these functions (tested on local with several generated networks).
Some notes:
EthBridger
andERC20Bridger
. Please let me know if you think they'd make more sense somewhere elseERC20Bridger.getGatewayInformation()
. That interface looks similar to TokenBridge fromdataEntities/network.ts
, but as I've added two new fields (l1Gateway and l2Gateway) I didn't want to touch too much the one in the network file.l1Gateway
andl2Gateway
correspond to the information of the gateway passed as parameter, which could be a custom gateway. Not sure about the naming, but please let me know of any good ideas you might have.deployBridge.ts