feat: add support L2 block range lookup for Orbit chains #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brtkx
changed the title
getBlockRangesForL1Block
brtkx
changed the title
gzeoneth
requested changes
Aug 15, 2023
src/lib/utils/lib.ts
Outdated
|
|
||
| while (start <= end) { | ||
| // Calculate the midpoint of the current range. | ||
| const mid = start + Math.floor((end - start) / 2) |
There was a problem hiding this comment.
I am a little bit unsure about these casting between BigNumber and number, it should be fine and I used it somewhere else in the sdk too.
gzeoneth
reviewed
Aug 16, 2023
gzeoneth
reviewed
Aug 16, 2023
src/lib/utils/lib.ts
Outdated
| maxL2Block?: number | 'latest' | ||
| }): Promise<number | undefined> { | ||
| if (!isArbitrumChain(provider)) { | ||
| throw new Error('Arbitrum provider is required.') |
There was a problem hiding this comment.
I suggest we assume the provider is L1 if its not Arbitrum, and return forL1Block
Comment on lines
+60
to
+67
| export const isArbitrumChain = async (provider: Provider): Promise<boolean> => { | ||
| try { | ||
| await ArbSys__factory.connect(ARB_SYS_ADDRESS, provider).arbOSVersion() | ||
| } catch (error) { | ||
| return false | ||
| } | ||
| return true | ||
| } |
There was a problem hiding this comment.
might want to do some caching here or in the network object, can do later
spsjvc
changed the title
…o l2-l1-message-orbit-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.