feat: add support for node.js v20 #370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dewanshparashar
approved these changes
Dec 12, 2023
spsjvc
changed the title
spsjvc
reviewed
Dec 13, 2023
package.json
Outdated
| @@ -91,4 +91,4 @@ | |||
| "files": [ | |||
| "dist/**/*" | |||
| ] | |||
| } | |||
| } | |||
There was a problem hiding this comment.
nitpick but let's bring back the newline character
There was a problem hiding this comment.
Is this still necessary now that we have matrix?
There was a problem hiding this comment.
nope. deleted 33cb6fd
spsjvc
reviewed
Dec 13, 2023
Co-authored-by: spsjvc <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the node v18 PR with this one to upgrade to node v20.
closes #297