-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for L3 chains #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o support-l2-parent-chains
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
yahgwai
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
L2Network
Added the following properties to make
L2Network
more consistent withL1Network
:blockTime: number
represents the minimum block time of the chainARB_MINIMUM_BLOCK_TIME_IN_SECONDS
partnerChainIDs: number[]
represents the ids of the children chainsparentChainId
property on theL2Network
and reconstructing the tree of networks when necessaryThe name
L2Network
is currently wrongly named, and it should be changed in a future version toArbitrumNetwork
orArbitrumChain
, because it can represent an L2 or an L3.Bridger, InboxTools
Updated the type of the
l1Network
property fromL1Network
toL1Network | L2Network
as it's referencing the parent chain which can now be anL2Network
. The changes mentioned above should make this seamless.