Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for L3 chains #379

Merged
merged 112 commits into from
Feb 5, 2024
Merged

feat: add support for L3 chains #379

merged 112 commits into from
Feb 5, 2024

Conversation

spsjvc
Copy link
Member

@spsjvc spsjvc commented Nov 23, 2023

L2Network

Added the following properties to make L2Network more consistent with L1Network:

  • blockTime: number represents the minimum block time of the chain
    • Added a new constant ARB_MINIMUM_BLOCK_TIME_IN_SECONDS
    • In v4, we can think about dropping this property altogether
  • partnerChainIDs: number[] represents the ids of the children chains
    • In v4, we can simplify this by just having a parentChainId property on the L2Network and reconstructing the tree of networks when necessary

The name L2Network is currently wrongly named, and it should be changed in a future version to ArbitrumNetwork or ArbitrumChain, because it can represent an L2 or an L3.

Bridger, InboxTools

Updated the type of the l1Network property from L1Network to L1Network | L2Network as it's referencing the parent chain which can now be an L2Network. The changes mentioned above should make this seamless.

Copy link

vercel bot commented Feb 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
arbitrum-sdk ❌ Failed (Inspect) Feb 5, 2024 8:45am

@spsjvc spsjvc changed the title feat: add support for orbit chains feat: add support for L3 chains Feb 2, 2024
@spsjvc spsjvc marked this pull request as ready for review February 5, 2024 09:53
@spsjvc spsjvc merged commit f0f3433 into main Feb 5, 2024
20 of 21 checks passed
@spsjvc spsjvc deleted the dl/query branch February 5, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants