Remove Hardcoded Version in README and Add Nicer Error #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gligneul
approved these changes
Jan 22, 2025
Comment on lines
+265
to
+268
| if e.msg.contains("pay_for_memory_grow") { | ||
| let msg = "Contract could not be activated as it is missing an entrypoint. \ | ||
| Please ensure that your contract has an #[entrypoint] defined on your main struct"; | ||
| bail!(msg); |
There was a problem hiding this comment.
This is nice! I wonder if this message should be on the SDK side, but I'm not sure if it is possible.
There was a problem hiding this comment.
The error comes from the Nitro backend, so I think we're kind of stuck here. It's a bit hacky, but it works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes a hardcoded version from the README.md and intercepts the common missing import error that is a result of not specifying an #[entrypoint] in contracts that users frequently run into.