Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove most occurences of log.Crit #2864

Merged
merged 4 commits into from
Jan 3, 2025
Merged

remove most occurences of log.Crit #2864

merged 4 commits into from
Jan 3, 2025

Conversation

tsahee
Copy link
Collaborator

@tsahee tsahee commented Jan 3, 2025

No description provided.

@cla-bot cla-bot bot added the s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA. label Jan 3, 2025
joshuacolvin0
joshuacolvin0 approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tsahee tsahee enabled auto-merge January 3, 2025 14:03
@tsahee tsahee merged commit a1606d2 into master Jan 3, 2025
16 checks passed
@tsahee tsahee deleted the remove_log_crit branch January 3, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

Assignees
No one assigned
Labels
design-approved s Automatically added by the CLA bot if the creator of a PR is registered as having signed the CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsahee @joshuacolvin0