Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Fixed Size Solidity Arrays in the SDK #20

Merged
merged 12 commits into from
Sep 6, 2023
Merged

Support Fixed Size Solidity Arrays in the SDK #20

merged 12 commits into from
Sep 6, 2023

Conversation

rauljordan
Copy link
Contributor

Adds support for:

sol_storage! {
    pub struct Contract {
        uint64[3] fixed;
    };

@rauljordan rauljordan marked this pull request as ready for review August 17, 2023 18:33
@rauljordan rauljordan mentioned this pull request Aug 17, 2023
Closed
rachel-bousfield
rachel-bousfield suggested changes Aug 17, 2023
View reviewed changes
Copy link
Contributor

@rachel-bousfield rachel-bousfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! We'll just want to make some changes to ensure the contents are inline and fully compatible with primitives :)

stylus-sdk/src/storage/array.rs Outdated Show resolved Hide resolved
stylus-sdk/src/storage/array.rs Outdated Show resolved Hide resolved
stylus-sdk/src/storage/array.rs Outdated Show resolved Hide resolved
@rauljordan
Copy link
Contributor Author

Thanks for the feedback @rachel-bousfield , I believe it should be ready again

rachel-bousfield
rachel-bousfield suggested changes Aug 17, 2023
View reviewed changes
stylus-sdk/src/storage/array.rs Outdated Show resolved Hide resolved
stylus-sdk/src/storage/array.rs Outdated Show resolved Hide resolved
stylus-sdk/src/storage/array.rs Outdated Show resolved Hide resolved
stylus-sdk/src/storage/array.rs Outdated Show resolved Hide resolved
stylus-sdk/src/storage/array.rs Outdated Show resolved Hide resolved
@hkalodner
Copy link

@cla-bot check

@cla-bot cla-bot bot added the s label Sep 1, 2023
@cla-bot
Copy link

cla-bot bot commented Sep 1, 2023

The cla-bot has been summoned, and re-checked this pull request!

@rachel-bousfield rachel-bousfield mentioned this pull request Sep 6, 2023
Merged
rachel-bousfield
rachel-bousfield approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@rachel-bousfield rachel-bousfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though I fixed a bug around multi-dimensional arrays so we should probs have someone else review too

@rachel-bousfield rachel-bousfield mentioned this pull request Sep 6, 2023
Merged
joshuacolvin0
joshuacolvin0 approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rauljordan rauljordan merged commit 749a709 into stylus Sep 6, 2023
@rachel-bousfield rachel-bousfield deleted the fixed-arrays branch September 6, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuacolvin0 joshuacolvin0 joshuacolvin0 approved these changes

@rachel-bousfield rachel-bousfield rachel-bousfield approved these changes

Assignees
No one assigned
Labels
s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rauljordan @hkalodner @rachel-bousfield @joshuacolvin0