Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix examples and doctest #219

Merged
merged 7 commits into from
Feb 5, 2025
Merged

Fix examples and doctest #219

merged 7 commits into from
Feb 5, 2025

Conversation

gligneul
Copy link
Contributor

@gligneul gligneul commented Feb 5, 2025

This PR fixes a few issues in the main branch.

This change avoids compiling the test and its dependencies on the wasm
target. This was leading to a compile error because a nested dependency
required to set a explicit feature for wasm.
This happends due to a limitation of doctest. See:
rust-lang/rust#67295
@gligneul gligneul marked this pull request as ready for review February 5, 2025 17:06
@rauljordan rauljordan merged commit b8af63d into main Feb 5, 2025
10 checks passed
@gligneul gligneul deleted the gligneul/fix-examples branch February 5, 2025 17:52
Copy link
Member

@joshuacolvin0 joshuacolvin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants