-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
noahdarveau/namespace eslint plugin #2690
Conversation
@@ -13,5 +13,6 @@ module.exports = { | |||
], | |||
'no-inner-declarations': 'off', | |||
'strict-null-checks/all': 'warn', | |||
'recommend-no-namespaces/recommend-no-namespaces': 'warn', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know there weren't a lot of items before you got here but please consider alphabetizing this and the plugins
list above. #Closed
"name": "eslint-plugin-recommend-no-namespaces", | ||
"version": "0.1.0", | ||
"license": "MIT", | ||
"author": "Noah", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
category: 'Best Practices', | ||
recommended: true, | ||
}, | ||
fixable: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this rule definition need to have a fix
section in the create
part in order to make it fixable? Is this a rule we really want to enable auto-fixing on? #Closed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🕐
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For more information about how to contribute to this repo, visit this page.
Description
Main changes in the PR:
Validation
Validation performed: