This repository was archived by the owner on Jun 18, 2024. It is now read-only.
Remove support for local Segoe UI #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t browsers where semilight does not work.
|
We've decided to go this route for now, as it's the safest way to ensure that the correct fonts are shown. We'll be investigating methods of loading local fonts in our products and will bring that functionality back to Fabric when it's been tested thoroughly in production. |
|
Reviewed in person with @Jahnp. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #960 by removing local Segoe UI from the font stacks altogether. This means that the Segoe UI web fonts will always be used, even if Segoe UI is installed locally. It's less performant but more reliable, and we can re-introduce support for local Segoe UI in the future when the [Chromium bug] is fixed.
This is an alternative to #961, which uses a browser hack to prevent Chromium browsers from using Segoe UI. My concern is that this may be fragile, and that it hasn't been tested thoroughly in scenarios like language overrides or when developers specify a custom font.