Skip to content

Commit

Permalink
feat(scripts): enable strict checking for additional sub-folders(pack…
Browse files Browse the repository at this point in the history
…ages) v4 (#25710)

* feat(scripts): enable strict checking for create-* and normalize those under generator/ boundary

* feat(scripts): enable strict checking for install hoos and normalize those under package-manager/ boundary

* feat(scripts): remove unused config/ folder

* feat(scripts): create utils/ subpackage with strict type checking

* feat(scripts): move generators related modules under generators/

* chore(scripts): remove obsolete functionality/modules

* feat(scripts): move execution related modules under executors/

* generate changefiles
  • Loading branch information
Hotell authored Nov 29, 2022
1 parent 9d164b9 commit a1ed5fe
Show file tree
Hide file tree
Showing 84 changed files with 181 additions and 749 deletions.
6 changes: 3 additions & 3 deletions .vscode/launch.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"name": "Debug test",
"type": "node",
"request": "launch",
"program": "${workspaceRoot}/scripts/debug-test.js",
"program": "${workspaceRoot}/scripts/executors/debug-test.js",
"cwd": "${fileDirname}",
"stopOnEntry": false,
"args": ["-i", "--watch"],
Expand All @@ -22,7 +22,7 @@
"name": "Debug current open test",
"type": "node",
"request": "launch",
"program": "${workspaceRoot}/scripts/debug-test.js",
"program": "${workspaceRoot}/scripts/executors/debug-test.js",
"cwd": "${fileDirname}",
"stopOnEntry": false,
"args": ["-i", "--testPathPattern=\\b${fileBasenameNoExtension}", "--watch"],
Expand All @@ -39,7 +39,7 @@
"name": "Debug current open test (v0)",
"type": "node",
"request": "launch",
"program": "${workspaceRoot}/scripts/debug-test.js",
"program": "${workspaceRoot}/scripts/executors/debug-test.js",
"cwd": "${fileDirname}",
"stopOnEntry": false,
"args": ["-i", "--testPathPattern=\\b${fileBasenameNoExtension}", "--watch"],
Expand Down
2 changes: 1 addition & 1 deletion azure-pipelines.release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ jobs:
displayName: 'Publish artifact: homepage.htm'

- script: |
node ./scripts/generate-package-manifest
node ./scripts/generators/generate-package-manifest
displayName: 'Generate package manifest'
- task: PublishBuildArtifacts@1
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "chore: update codepen scripts task alias path",
"packageName": "@fluentui/react",
"email": "[email protected]",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "chore: update token-pipeline scripts task alias path",
"packageName": "@fluentui/react-theme",
"email": "[email protected]",
"dependentChangeType": "none"
}
28 changes: 15 additions & 13 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -19,41 +19,41 @@
"buildto": "lage build --verbose --to",
"buildto:lerna": "node ./scripts/monorepo/buildTo.js",
"bundle": "lage bundle --verbose",
"bundlesizecollect": "node ./scripts/bundle-size-collect",
"bundlesizecollect": "node ./scripts/generators/bundle-size-collect",
"change": "beachball change --no-commit",
"check:change": "beachball check",
"check:modified-files": "yarn workspace @fluentui/scripts just check-for-modified-files",
"check:affected-package": "node ./scripts/monorepo/checkIfPackagesAffected.js",
"check:installed-dependencies-versions": "satisfied --skip-invalid --ignore \"prettier|angular|lit|sass|@storybook/html|@storybook/mdx2-csf|svelte|@testing-library|vue|@cypress/react|cypress|@swc/wasm|@cactuslab/usepubsub\"",
"clean": "lage clean --verbose",
"code-style": "lage code-style --verbose",
"codepen": "cd packages/react && node ../../scripts/local-codepen.js",
"copy-notices": "node scripts/copy-notices.js",
"create-component": "plop --plopfile ./scripts/create-component/create-component.ts --dest . --require ./scripts/ts-node-register",
"create-package": "plop --plopfile ./scripts/create-package/plopfile.ts --dest . --require ./scripts/ts-node-register",
"codepen": "cd packages/react && node ../../scripts/executors/local-codepen.js",
"copy-notices": "node scripts/generators/copy-notices.js",
"create-component": "plop --plopfile ./scripts/generators/create-component/index.ts --dest . --require ./scripts/ts-node-register",
"create-package": "plop --plopfile ./scripts/generators/create-package/index.ts --dest . --require ./scripts/ts-node-register",
"e2e": "lage e2e --verbose --concurrency=1",
"format": "node scripts/format.js",
"format": "node scripts/executors/format.js",
"generate-version-files": "yarn workspace @fluentui/scripts just generate-version-files",
"graph": "node ./scripts/dependency-graph-generator/index.js",
"lint": "lage lint --verbose",
"lint:log": "FORCE_COLOR=0 yarn lint > lint.log 2>&1",
"lint:log:lerna": "FORCE_COLOR=0 lerna run lint --stream --no-bail > lint.log 2>&1",
"perf": "cross-env PERF=true gulp perf --times=100",
"perf:debug": "cross-env PERF=true gulp perf:debug --debug",
"postinstall": "node ./scripts/postinstall.js",
"preinstall": "node ./scripts/use-yarn-please.js",
"postinstall": "node ./scripts/package-manager/postinstall.js",
"preinstall": "node ./scripts/package-manager/use-yarn-please.js",
"publish:beachball": "beachball publish -b origin/master --access public -y",
"rebuild": "node ./scripts/invalidate-just-cache.js && yarn build --reset-cache",
"rebuild": "node ./scripts/executors/invalidate-just-cache.js && yarn build --reset-cache",
"release:fluentui:canary": "node -r ./scripts/ts-node-register ./scripts/fluentui-publish publish-canary",
"release:fluentui:minor": "node -r ./scripts/ts-node-register ./scripts/fluentui-publish publish-minor",
"release:fluentui:pack-nightly": "node -r ./scripts/ts-node-register ./scripts/fluentui-publish pack-nightly",
"release:fluentui:patch": "node -r ./scripts/ts-node-register ./scripts/fluentui-publish publish-patch",
"release:fluentui:post-validation": "node -r ./scripts/ts-node-register ./scripts/fluentui-publish post-publish",
"rename-package": "node -r ./scripts/ts-node-register ./scripts/rename-package.ts",
"rename-package": "node -r ./scripts/ts-node-register ./scripts/generators/rename-package.ts",
"run:published": "node ./scripts/monorepo/runPublished.js",
"runto:lerna": "node ./scripts/monorepo/runTo.js",
"scrub": "node ./scripts/scrub.js",
"start": "node scripts/start.js",
"scrub": "node ./scripts/executors/scrub.js",
"start": "node ./scripts/executors/start.js",
"start:northstar": "yarn workspace @fluentui/docs start",
"stats:build": "gulp stats",
"stats:save": "gulp stats:save",
Expand Down Expand Up @@ -157,6 +157,7 @@
"@types/node-fetch": "2.5.7",
"@types/prettier": "2.2.3",
"@types/progress": "2.0.5",
"@types/prompts": "2.4.1",
"@types/react": "17.0.44",
"@types/react-dom": "17.0.15",
"@types/react-is": "17.0.3",
Expand Down Expand Up @@ -219,8 +220,8 @@
"express": "4.17.1",
"extract-comments": "1.1.0",
"file-loader": "6.2.0",
"fork-ts-checker-webpack-plugin": "6.1.0",
"find-free-port": "2.0.0",
"fork-ts-checker-webpack-plugin": "6.1.0",
"fs-extra": "8.1.0",
"geckodriver": "3.0.2",
"glob": "7.2.0",
Expand Down Expand Up @@ -262,6 +263,7 @@
"prettier": "2.2.1",
"pretty-bytes": "5.6.0",
"progress": "2.0.3",
"prompts": "2.4.2",
"puppeteer": "14.4.0",
"raw-loader": "4.0.2",
"react": "17.0.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/react-components/react-theme/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"start": "yarn storybook",
"storybook": "start-storybook",
"test": "jest --passWithNoTests",
"token-pipeline": "node -r ../../../scripts/ts-node-register ../../../scripts/token-pipeline.ts",
"token-pipeline": "node -r ../../../scripts/ts-node-register ../../../scripts/generators/token-pipeline.ts",
"type-check": "tsc -b tsconfig.json",
"generate-api": "tsc -p ./tsconfig.lib.json --emitDeclarationOnly && just-scripts api-extractor"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"build-storybook": "cross-env NODE_OPTIONS=--max-old-space-size=3072 just-scripts storybook:build",
"clean": "just-scripts clean",
"code-style": "just-scripts code-style",
"codepen": "node ../../scripts/local-codepen.js",
"codepen": "node ../../scripts/executors/local-codepen.js",
"e2e": "yarn workspace @fluentui/react-examples cypress run --component",
"e2e:local": "yarn workspace @fluentui/react-examples cypress open --component",
"just": "just-scripts",
Expand Down
185 changes: 0 additions & 185 deletions scripts/CHANGELOG.json

This file was deleted.

Loading

0 comments on commit a1ed5fe

Please sign in to comment.