feat(scripts): enable strict checking for additional sub-folders(packages) v4 #25710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e under generator/ boundary
…those under package-manager/ boundary
Hotell
changed the title
📊 Bundle size reportUnchanged fixtures
|
Hotell
commented
Nov 18, 2022
| @@ -7,7 +7,8 @@ import _ from 'lodash'; | |||
| import chalk from 'chalk'; | |||
| import { spawnSync } from 'child_process'; | |||
| import { WorkspaceJsonConfiguration } from '@nrwl/devkit'; | |||
| import { findGitRoot, PackageJson } from '../monorepo/index'; | |||
|
|
|||
There was a problem hiding this comment.
fixed type errors and normalized name to follow our nx generarators -> index.ts as root
| @@ -6,10 +6,11 @@ import * as fs from 'fs-extra'; | |||
| import * as os from 'os'; | |||
| import * as path from 'path'; | |||
| import { execSync } from 'child_process'; | |||
| import { findGitRoot, getAllPackageInfo, isConvergedPackage } from '../monorepo/index'; | |||
There was a problem hiding this comment.
fixed type errors and normalized name to follow our nx generarators -> index.ts as root
| @@ -0,0 +1,9 @@ | |||
| const fs = require('fs'); | |||
There was a problem hiding this comment.
removed fs-extra as fs is enables same behaviours
this was moved rather than created. whats wrong with you git ? :D
| @@ -1,65 +0,0 @@ | |||
| const chokidar = require('chokidar'); | |||
| @@ -1,74 +0,0 @@ | |||
| const fs = require('fs-extra'); | |||
Closed
18 tasks
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1336 | 1251 | 5000 | |
| Button | mount | 905 | 921 | 5000 | |
| FluentProvider | mount | 1483 | 1423 | 5000 | |
| FluentProviderWithTheme | mount | 599 | 637 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 539 | 520 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 555 | 559 | 10 | |
| MakeStyles | mount | 1739 | 1778 | 50000 | |
| SpinButton | mount | 2305 | 2395 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 13bba00:
|
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| LayoutMinimalPerf.default | 324 | 310 | 1.05:1 |
| IconMinimalPerf.default | 565 | 538 | 1.05:1 |
| DividerMinimalPerf.default | 315 | 303 | 1.04:1 |
| RefMinimalPerf.default | 187 | 179 | 1.04:1 |
| TextAreaMinimalPerf.default | 407 | 391 | 1.04:1 |
| AvatarMinimalPerf.default | 162 | 157 | 1.03:1 |
| CarouselMinimalPerf.default | 357 | 348 | 1.03:1 |
| FlexMinimalPerf.default | 255 | 247 | 1.03:1 |
| ListNestedPerf.default | 483 | 471 | 1.03:1 |
| SegmentMinimalPerf.default | 307 | 299 | 1.03:1 |
| AnimationMinimalPerf.default | 468 | 459 | 1.02:1 |
| AttachmentMinimalPerf.default | 123 | 121 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 216 | 212 | 1.02:1 |
| LoaderMinimalPerf.default | 266 | 262 | 1.02:1 |
| ProviderMinimalPerf.default | 322 | 317 | 1.02:1 |
| ReactionMinimalPerf.default | 332 | 326 | 1.02:1 |
| StatusMinimalPerf.default | 604 | 595 | 1.02:1 |
| TooltipMinimalPerf.default | 1881 | 1850 | 1.02:1 |
| AttachmentSlotsPerf.default | 892 | 879 | 1.01:1 |
| BoxMinimalPerf.default | 291 | 289 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1025 | 1014 | 1.01:1 |
| ButtonSlotsPerf.default | 423 | 418 | 1.01:1 |
| CardMinimalPerf.default | 468 | 462 | 1.01:1 |
| ChatMinimalPerf.default | 639 | 633 | 1.01:1 |
| DropdownManyItemsPerf.default | 537 | 534 | 1.01:1 |
| DropdownMinimalPerf.default | 2164 | 2144 | 1.01:1 |
| GridMinimalPerf.default | 293 | 290 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 977 | 966 | 1.01:1 |
| ListWith60ListItems.default | 495 | 489 | 1.01:1 |
| MenuMinimalPerf.default | 729 | 723 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1364 | 1344 | 1.01:1 |
| RosterPerf.default | 1705 | 1695 | 1.01:1 |
| PopupMinimalPerf.default | 555 | 549 | 1.01:1 |
| PortalMinimalPerf.default | 138 | 136 | 1.01:1 |
| SkeletonMinimalPerf.default | 299 | 295 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3297 | 3265 | 1.01:1 |
| TableMinimalPerf.default | 356 | 354 | 1.01:1 |
| CustomToolbarPrototype.default | 2170 | 2150 | 1.01:1 |
| ToolbarMinimalPerf.default | 801 | 795 | 1.01:1 |
| AlertMinimalPerf.default | 224 | 225 | 1:1 |
| DatepickerMinimalPerf.default | 4633 | 4620 | 1:1 |
| EmbedMinimalPerf.default | 2635 | 2646 | 1:1 |
| HeaderMinimalPerf.default | 319 | 318 | 1:1 |
| HeaderSlotsPerf.default | 682 | 681 | 1:1 |
| ImageMinimalPerf.default | 341 | 340 | 1:1 |
| LabelMinimalPerf.default | 340 | 340 | 1:1 |
| ListCommonPerf.default | 511 | 512 | 1:1 |
| SliderMinimalPerf.default | 1227 | 1223 | 1:1 |
| TableManyItemsPerf.default | 1573 | 1566 | 1:1 |
| TreeMinimalPerf.default | 699 | 699 | 1:1 |
| CheckboxMinimalPerf.default | 1513 | 1525 | 0.99:1 |
| DialogMinimalPerf.default | 682 | 687 | 0.99:1 |
| FormMinimalPerf.default | 324 | 327 | 0.99:1 |
| InputMinimalPerf.default | 850 | 856 | 0.99:1 |
| ListMinimalPerf.default | 450 | 455 | 0.99:1 |
| ProviderMergeThemesPerf.default | 986 | 991 | 0.99:1 |
| RadioGroupMinimalPerf.default | 384 | 386 | 0.99:1 |
| TextMinimalPerf.default | 295 | 300 | 0.98:1 |
| ChatWithPopoverPerf.default | 284 | 292 | 0.97:1 |
| VideoMinimalPerf.default | 609 | 626 | 0.97:1 |
| ButtonMinimalPerf.default | 131 | 136 | 0.96:1 |
| AccordionMinimalPerf.default | 115 | 123 | 0.93:1 |
| TreeWith60ListItems.default | 121 | 132 | 0.92:1 |
🕵 fluentuiv8 Open the Visual Regressions report to inspect the 2 screenshots✅ There was 2 screenshots added, 0 screenshots removed, 1037 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference. unknown 2 screenshots
|
🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots✅ There was 0 screenshots added, 0 screenshots removed, 1749 screenshots unchanged, 0 screenshots with different dimensions and 2 screenshots with visible difference. unknown 2 screenshots
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1205 | 1198 | 5000 | |
| Breadcrumb | mount | 2810 | 2773 | 1000 | |
| Checkbox | mount | 2611 | 2619 | 5000 | |
| CheckboxBase | mount | 2369 | 2384 | 5000 | |
| ChoiceGroup | mount | 4250 | 4285 | 5000 | |
| ComboBox | mount | 1174 | 1148 | 1000 | |
| CommandBar | mount | 9258 | 9225 | 1000 | |
| ContextualMenu | mount | 10175 | 10099 | 1000 | |
| DefaultButton | mount | 1372 | 1370 | 5000 | |
| DetailsRow | mount | 3377 | 3332 | 5000 | |
| DetailsRowFast | mount | 3382 | 3381 | 5000 | |
| DetailsRowNoStyles | mount | 3224 | 3239 | 5000 | |
| Dialog | mount | 2992 | 2984 | 1000 | |
| DocumentCardTitle | mount | 586 | 585 | 1000 | |
| Dropdown | mount | 3175 | 3148 | 5000 | |
| FocusTrapZone | mount | 1970 | 1953 | 5000 | |
| FocusZone | mount | 1933 | 1963 | 5000 | |
| GroupedList | mount | 1848 | 2058 | 2 | |
| GroupedList | virtual-rerender | 1102 | 1089 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 1603 | 1618 | 2 | |
| GroupedListV2 | mount | 575 | 553 | 2 | |
| GroupedListV2 | virtual-rerender | 547 | 553 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 559 | 568 | 2 | |
| IconButton | mount | 1778 | 1815 | 5000 | |
| Label | mount | 751 | 756 | 5000 | |
| Layer | mount | 4199 | 4206 | 5000 | |
| Link | mount | 858 | 844 | 5000 | |
| MenuButton | mount | 1614 | 1623 | 5000 | |
| MessageBar | mount | 2311 | 2379 | 5000 | |
| Nav | mount | 3037 | 3057 | 1000 | |
| OverflowSet | mount | 1419 | 1401 | 5000 | |
| Panel | mount | 2490 | 2494 | 1000 | |
| Persona | mount | 1253 | 1257 | 1000 | |
| Pivot | mount | 1525 | 1518 | 1000 | |
| PrimaryButton | mount | 1482 | 1497 | 5000 | |
| Rating | mount | 6906 | 6930 | 5000 | |
| SearchBox | mount | 1532 | 1512 | 5000 | |
| Shimmer | mount | 2949 | 2915 | 5000 | |
| Slider | mount | 2124 | 2118 | 5000 | |
| SpinButton | mount | 4263 | 4275 | 5000 | |
| Spinner | mount | 831 | 880 | 5000 | |
| SplitButton | mount | 2801 | 2845 | 5000 | |
| Stack | mount | 865 | 871 | 5000 | |
| StackWithIntrinsicChildren | mount | 2357 | 2332 | 5000 | |
| StackWithTextChildren | mount | 5010 | 5040 | 5000 | |
| SwatchColorPicker | mount | 10355 | 9506 | 5000 | |
| TagPicker | mount | 2338 | 2337 | 5000 | |
| TeachingBubble | mount | 75786 | 76250 | 5000 | |
| Text | mount | 814 | 818 | 5000 | |
| TextField | mount | 1566 | 1538 | 5000 | |
| ThemeProvider | mount | 1448 | 1430 | 5000 | |
| ThemeProvider | virtual-rerender | 1156 | 1149 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1998 | 2022 | 5000 | |
| Toggle | mount | 1132 | 1156 | 5000 | |
| buttonNative | mount | 556 | 540 | 5000 |
Hotell
force-pushed
the
hotell/build/scripts/ts-solution-config-v4
branch
from
b1e1dff to
51a9967
Compare
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 13271460c38e2e38244c9b5a4cb713159570874d (build) |
Hotell
force-pushed
the
hotell/build/scripts/ts-solution-config-v4
branch
from
7d41cd7 to
13bba00
Compare
1 task
layershifter
approved these changes
Nov 22, 2022
ling1726
approved these changes
Nov 22, 2022
spmonahan
approved these changes
Nov 28, 2022
TristanWatanabe
approved these changes
Nov 28, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Nov 29, 2022
* master: (34 commits) chore(react-tooltip): migrate to new package structure (microsoft#25818) chore(react-field): migrate to new package structure (microsoft#25817) Update vr screenshotdiff lib to accept vr host url as param (microsoft#25772) feat(scripts): enable strict checking for additional sub-folders(packages) v4 (microsoft#25710) fix(tools): bump norhtstar packages v9 deps on dep mismatch resolution (microsoft#25806) feat: remove react-storybook and replace its functionality via standard react-storybook-addon package (microsoft#25786) applying package updates chore(react-spinbutton): migrate to new package structure (microsoft#25813) chore(react-spinner): migrate to new package structure (microsoft#25814) chore(react-provider): migrate to new package structure (microsoft#25809) chore(react-radio, shared-contexts): migrate to new package structure (microsoft#25810) chore(react-theme): migrate to new package structure (microsoft#25812) docs: add Fluent UI Insights EP04 to README (microsoft#25775) chore(react-migration-v8-v9): use same build process/setup as v9/ts-solution packages (microsoft#25679) docs: Improves `Table` documentation (microsoft#25787) feat: improve react-18 tests (microsoft#25758) docs: Add examples for DataGrid (microsoft#25783) chore(react-tree): scaffold TreeItemLayout (microsoft#25781) perf: make ts-minbar test compilation faster and asset preparation simpler (microsoft#25754) chore: creates TreeItem and basic Tree (microsoft#25742) ...
Hotell
added a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
…ages) v4 (microsoft#25710) * feat(scripts): enable strict checking for create-* and normalize those under generator/ boundary * feat(scripts): enable strict checking for install hoos and normalize those under package-manager/ boundary * feat(scripts): remove unused config/ folder * feat(scripts): create utils/ subpackage with strict type checking * feat(scripts): move generators related modules under generators/ * chore(scripts): remove obsolete functionality/modules * feat(scripts): move execution related modules under executors/ * generate changefiles
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
/package-manager/generators/executors/utilsRelated Issue(s)
/scripts) #24349