Use repl.send-signal to interrupt stdio REPLs #499
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor nit but I noticed that the stdio-based clients use two equivalent implementations of the
interrupt
function. This PR makes the implementation the same for these clients:by using the:
send-signal
function defined inremote/stdio.fnl
vim.loop.constants.SIGINT
constant instead of the number 2comment-prefix
of the client's languageHopefully, this provides consistency and emphasizes the use of the base client functionality of
remote/stdio.fnl
.I didn't include the Scheme client because there is #498 which adds the ability to interrupt the REPL.