Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support clj-reload in addition to tools.namespace #576

Merged
merged 1 commit into from
May 11, 2024

Conversation

dharrigan
Copy link
Contributor

@dharrigan dharrigan commented May 6, 2024

Since version 0.46.0, nREPL has supported the clj-reload library in addition to the standard tools.namespace library for facilitating reloading namespaces.

This commit introduces a new Clojure nREPL variable to allow switching to the new clj-reload library.

The variable is:

g:conjure#client#clojure#nrepl#refresh#backend

The default is to continue to use tools.namespace, but if it is set to clj-reload, i.e.,

g:conjure#client#clojure#nrepl#refresh#backend = 'clj-reload'

It will then use the new backend.

fixes #574

-=david=-

Since version 0.46.0, nREPL has supported the `clj-reload` library in
addition to the standard `tools.namespace` library for facilitating
reloading namespaces.

This commit introduces a new Clojure nREPL variable to allow switching
to the new `clj-reload` library.

The variable is:

`g:conjure#client#clojure#nrepl#refresh#backend`

The default is to continue to use `tools.namespace`, but if it is set to
`clj-reload`, i.e.,

`g:conjure#client#clojure#nrepl#refresh#backend = 'clj-reload'`

It will then use the new backend.

fixes Olical#574

-=david=-
@dharrigan dharrigan force-pushed the feat/issue-574-support-clj-reload branch from f0874e3 to 6b99860 Compare May 6, 2024 19:36
Copy link
Owner

@Olical Olical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks perfect, thank you very much! Going to merge it locally and give it a whirl before merging to develop. If everything looks stable I'll release ASAP and notify people of the config they need to activate it.

The backend to use for "refreshing" the namespaces. It defaults
to `tools.namespace` (which has been there since the beginning) or
if the value is `clj-reload` it uses the new `clj-reload` feature
available since nREPL 0.46.0 (released 2024-03-05).
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect explanation chefs kiss

@Olical Olical merged commit 6b99860 into Olical:develop May 11, 2024
2 checks passed
@Olical
Copy link
Owner

Olical commented May 11, 2024

Works great! On develop now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants