Made yii2-multilingual-behavior more extensible. #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ddinchev I'll merge your pull request when you repair the tests |
|
Ah, yes, sorry - I didn't run the tests and hadn't commit the whole thing properly. I've fixed my commit. |
|
@ddinchev thanks! |
OmgDef
added a commit
that referenced
this pull request
Feb 12, 2016
Made yii2-multilingual-behavior more extensible.
|
@OmgDef given that you merged this into master - could you bump the version (e.g. 2.1.2) so that composer picks up the update? |
|
@ddinchev done |
|
@OmgDef thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
$langClassSuffixproperty is now configurable (I use theMLsuffix for historical reasons - same as my table suffix).Also I wanted to set the
$currentLanguageproperty from a subclass and noticed it was private. This actually was by mistake - I see there is a checkif (!$this->currentLanguage)but if the property is private, that would never evaluate tofalse. So I changed it to public instead.