fix: avoid extra ToC rerun warnings when the ToC hasn't changed #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stripping positions from ToC entries avoid a mere text change that would not affect the ToC (same title, same page, only some inner character position changed) to be seen as a difference.
Omikhleia
force-pushed
the
avoid-extra-toc-rerun-warning
branch
from
97cd1df to
8a31594
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stripping positions from ToC entries avoids a mere text change that would not affect the ToC (same title, same page, only some inner character position changed) to be seen as a difference.
Implemented as a resilient "hack", but see also SILE sile-typesetter/sile#1732 for the more general context.
(The "problem" occurs when some ToC entries contain commands, e.g. an emphasis etc.)