Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure running chapter or section headers land on the correct page #54

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

Omikhleia
Copy link
Owner

Closes #43

A workaround, rather than a true fix, with ugly hacks in the sectioning logic and the section hooks.
We should reconsider these hooks one day, but it will break existing style files, so that can't be addressed in 2.x

@Omikhleia Omikhleia added the bug Something isn't working label Aug 17, 2023
@Omikhleia Omikhleia self-assigned this Aug 17, 2023
@Omikhleia Omikhleia added this to the 2.1 milestone Aug 17, 2023
@Omikhleia Omikhleia changed the base branch from main to 2.1a August 17, 2023 12:53
@Omikhleia Omikhleia merged commit 5efc826 into 2.1a Aug 17, 2023
@Omikhleia Omikhleia deleted the fix-header-workaround-43 branch August 17, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect running header initialization in absence of odd header
1 participant