Added delegate handlers for all base interfaces #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok - will look into surfacing those APIs on the client next week :) |
…llation tokens everywhere. Added generic extension methods for onrequest and onnotification
|
Nice work on propagating cancellation tokens :) |
|
@NTaylorMullen This will involve some (hopefully minor) breaking changes, I'll make the next version number reflect this. Let me know if you have any concerns, it'll be a few days before I get back to this. |
|
All good. WIll consume once they're in 😄 |
…ic code and error object back to the other side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@tintoy We should now have parity between the client and server in terms of requests / notifications for both sides. We should look at the client to figure out how best to pull those in.