Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for Definition, DocumentHighlights, FoldingRanges to TextDocumentClient. #188

Merged
merged 3 commits into from
Nov 6, 2019
Merged

Added support for Definition, DocumentHighlights, FoldingRanges to TextDocumentClient. #188

merged 3 commits into from
Nov 6, 2019

Conversation

ezolotko
Copy link
Contributor

See #170.

@david-driscoll
Copy link
Member

@tintoy any input?

tintoy
tintoy approved these changes Oct 27, 2019
View reviewed changes
Copy link
Collaborator

@tintoy tintoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@ezolotko
Copy link
Contributor Author

ezolotko commented Nov 6, 2019

@david-driscoll @tintoy Any resolution on this PR? Should it be merged?

@tintoy
Copy link
Collaborator

tintoy commented Nov 6, 2019

Sorry! I completely forgot about this one. Will do now :)

@tintoy tintoy merged commit 09fc4f3 into OmniSharp:master Nov 6, 2019
@tintoy
Copy link
Collaborator

tintoy commented Nov 6, 2019

Thanks for contributing and sorry for the delay!

@ezolotko ezolotko deleted the textdocumentclient-lsp-capabilities-support branch November 7, 2019 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tintoy tintoy tintoy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezolotko @david-driscoll @tintoy