Fixed how partial items are scheduled #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ill fix flakey tests, as well as possible edge cases where partial items are consumed in rapid succession
david-driscoll
force-pushed
the
temp/remove-retry-facts
branch
3 times, most recently
from
3ddfa0f to
d2a1a5c
Compare
Codecov Report
@@ Coverage Diff @@
## master #565 +/- ##
==========================================
+ Coverage 73.39% 73.79% +0.40%
==========================================
Files 256 256
Lines 12248 12373 +125
Branches 826 829 +3
==========================================
+ Hits 8989 9131 +142
+ Misses 3259 3242 -17
Continue to review full report at Codecov.
|
david-driscoll
force-pushed
the
temp/remove-retry-facts
branch
2 times, most recently
from
08a9f6f to
8f18364
Compare
david-driscoll
force-pushed
the
temp/remove-retry-facts
branch
from
8f18364 to
74660a7
Compare
…thod is called to avoid a race condition where no value is picked up potentially
david-driscoll
force-pushed
the
temp/remove-retry-facts
branch
from
049e58c to
9003a11
Compare
This reverts commit 1a10461.
david-driscoll
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added schedulers everywhere they make sense.
Ensure OutputHandler is run in order as much as possible
Ensure that progress params are ordered serially to ensure they are completed before the related request is finished.
Removed a whole lot of
[RetryFact]to ensure that possible issues surface earlier.