Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean System.IO.Pipelines explicit dependency #595

Conversation

jairbubbles
Copy link

I got that exception during the startup of my application:

System.MissingMethodException: Method not found: 'System.Threading.Tasks.ValueTask System.IO.Pipelines.PipeWriter.CompleteAsync(System.Exception)'.

With stack trace:

   at Nerdbank.Streams.PipeExtensions.<>c__DisplayClass19_0.<<UsePipeReader>b__2>d.MoveNext() in D:\a\1\s\src\Nerdbank.Streams\PipeExtensions.cs:line 546
   at System.Runtime.CompilerServices.AsyncTaskMethodBuilder.Start[TStateMachine](TStateMachine& stateMachine) in f:\dd\ndp\clr\src\BCL\system\runtime\compilerservices\AsyncMethodBuilder.cs:line 322
   at Nerdbank.Streams.PipeExtensions.<>c__DisplayClass19_0.<UsePipeReader>b__2()
   at System.Threading.Tasks.Task`1.InnerInvoke() in f:\dd\ndp\clr\src\BCL\system\threading\Tasks\Future.cs:line 680
   at System.Threading.Tasks.Task.Execute() in f:\dd\ndp\clr\src\BCL\system\threading\Tasks\Task.cs:line 2498

I don't completely understand why I get this but the dependency tree is a bit complex so I feel like simplifying would improve the situation. System.IO.Pipelines is inherited by dependency to NerdBank.Streams so we should not explictely reference it.

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@f74bfcf). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #595   +/-   ##
=========================================
  Coverage          ?   69.31%           
=========================================
  Files             ?      257           
  Lines             ?    12576           
  Branches          ?      848           
=========================================
  Hits              ?     8717           
  Misses            ?     3587           
  Partials          ?      272           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f74bfcf...e55625a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant