Merge pull request #1894 from 333fred/fix-italics

Fix lack of trailing italics
OmniSharp · Aug 18, 2020 · b28a4ae · b28a4ae
2 parents 07c6898 + 1738c27
commit b28a4ae
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 0 deletions.
diff --git a/src/OmniSharp.Roslyn.CSharp/Helpers/MarkdownHelpers.cs b/src/OmniSharp.Roslyn.CSharp/Helpers/MarkdownHelpers.cs
@@ -189,6 +189,7 @@ public static void TaggedTextToMarkdown(
                             stringBuilder.Append('`');
                         }
                         stringBuilder.Append(current.Text);
+                        brokeLine = false;
                         break;
                 }
             }
@@ -198,10 +199,16 @@ public static void TaggedTextToMarkdown(
                 endBlock();
             }
 
+            if (!brokeLine && markdownFormat == MarkdownFormat.Italicize)
+            {
+                stringBuilder.Append("_");
+            }
+
             return;
 
             void addText(string text)
             {
+                brokeLine = false;
                 afterFirstLine = true;
                 if (!isInCodeBlock)
                 {

diff --git a/tests/OmniSharp.Roslyn.CSharp.Tests/QuickInfoProviderFacts.cs b/tests/OmniSharp.Roslyn.CSharp.Tests/QuickInfoProviderFacts.cs
@@ -709,6 +709,23 @@ public static void A()
             Assert.Equal("```csharp\nvoid Program.B()\n```\n\n\\*This should be escaped\\*", response.Markdown);
         }
 
+        [Fact]
+        public async Task NullableIsItalicized()
+        {
+            string content = @"
+#nullable enable
+class Program
+{
+    public static void A(string s)
+    {
+        _ = s$$;
+    }
+
+}";
+            var response = await GetTypeLookUpResponse(content);
+            Assert.Equal("```csharp\n(parameter) string s\n```\n\n_'s' is not null here\\._", response.Markdown);
+        }
+
         private async Task<QuickInfoResponse> GetTypeLookUpResponse(string content)
         {
             TestFile testFile = new TestFile("dummy.cs", content);