Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1269. #1346

Merged
merged 2 commits into from
Dec 11, 2018
Merged

Fixes #1269. #1346

merged 2 commits into from
Dec 11, 2018

Conversation

LoneBoco
Copy link
Contributor

Command line arguments were checked in an incorrect way.

Command line arguments were checked in an incorrect way.
@LoneBoco
Copy link
Contributor Author

I set stdio to true because under the current code it seems it was intended to always be true.

@rchande
Copy link

rchande commented Nov 27, 2018

@david-driscoll Does this sound right to you?

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@david-driscoll david-driscoll merged commit 1cc5321 into OmniSharp:master Dec 11, 2018
@LoneBoco LoneBoco deleted the fix-cmd-arguments branch December 12, 2018 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants