Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ToLanguageVersion switch with TryParse #1488

Merged
merged 1 commit into from
May 14, 2019

Conversation

FiniteReality
Copy link
Contributor

This should fix #1487.

I wasn't able to run the build.sh script to run the unit tests for some reason, as I was getting this response:

$ ./build.sh
Index was outside the bounds of the array.
Could not restore NuGet packages.

I'm not entirely sure why I was getting this, but I'm pretty certain I installed Mono correctly, as the snippets they gave to test the installation ran correctly.

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! LGTM

@filipw filipw merged commit 99af853 into OmniSharp:master May 14, 2019
@FiniteReality FiniteReality deleted the fix-missing-lang-versions branch May 14, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No support for 'preview' language versions?
2 participants