Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mistake on shadow copying assembly loader. #1497

Merged

Conversation

savpek
Copy link
Contributor

@savpek savpek commented May 15, 2019

Double checked implementation based on original from roslyn and found important bit that was missing, this may fix issue #1496

Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filipw
Copy link
Member

filipw commented May 15, 2019

it should fix it I think, the linked issue looks like a bindings redirect issue indeed

@filipw
Copy link
Member

filipw commented May 16, 2019

I have pulled this one locally and tested, and indeed it fixes #1496
since this is code directly from Roslyn, I think it should be safe to merge- thanks

@filipw filipw merged commit 479ce0c into OmniSharp:master May 16, 2019
@filipw filipw mentioned this pull request May 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants