Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use msbuild from Mono 6.4.0 on linux/macos #1612

Merged
merged 11 commits into from
Sep 28, 2019

Conversation

filipw
Copy link
Member

@filipw filipw commented Sep 26, 2019

This is a follow up to #1606

We now copy the MsBuild 16.3 from Mono 6.4.0, rather than the custom package we had in the past.

Copy link
Member

@david-driscoll david-driscoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this passes CI :shipit:

This may increase the size of the output assets, so we should review with that @rchande and @akshita31 to make sure it's too much larger when consumed from the vscode plugin.

@@ -2,7 +2,7 @@
"DotNetInstallScriptURL": "https://dot.net/v1",
"DotNetChannel": "preview",
"DotNetVersion": "2.1.505",
"RequiredMonoVersion": "5.18.0.0",
"RequiredMonoVersion": "6.0.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a short explanation why this isn't 6.4.0 here - there is no 6.4.0 for travis yet (unless we customize the build and install manually which I want to avoid) so the build would fail.

It doesn't really matter since on ADO we explicitly set 6.4.0 and build with that version, and this is where the real "publishing" happens. Plus we have #1569 pending and at that point we can stop worrying about travis too.

As soon as #1569 is done or travis has 6.4.0, we can raise the version in this file too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what you're saying is you want me to disconnect travis and appveyor.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exactly, I think it adds maintenance overhead unnecessarily - and we really can get (and we do get) everything done via Azure DevOps already anyway

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this passes CI :shipit:

This may increase the size of the output assets, so we should review with that @rchande and @akshita31 to make sure it's too much larger when consumed from the vscode plugin.

I checked the outputs from the current master and this change... and the was no real large change in overall zip size. It looked to be about 50KB at most, so

@filipw filipw force-pushed the bugfix/msbuild16.3-nix branch from 39f8b30 to 6ce4ab2 Compare September 27, 2019 09:12
Microsoft.Build.{Tasks,Utilities}.v{4,12}.0
@filipw filipw force-pushed the bugfix/msbuild16.3-nix branch from 6ce4ab2 to 0431225 Compare September 27, 2019 09:16
@filipw
Copy link
Member Author

filipw commented Sep 27, 2019

This may increase the size of the output assets

we only copy core MSBuild libs (no MSBuild runtime) here (which we already did anyway, it's just we take it from Mono 6.4.0 now) so the size is more or less the same

@david-driscoll david-driscoll merged commit 0d90be9 into master Sep 28, 2019
@filipw filipw deleted the bugfix/msbuild16.3-nix branch October 17, 2019 05:43
@filipw filipw mentioned this pull request Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants