Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to the latest lsp library #1815

Merged
merged 36 commits into from
Jul 28, 2020
Merged

Upgrade to the latest lsp library #1815

merged 36 commits into from
Jul 28, 2020

Conversation

david-driscoll
Copy link
Member

@david-driscoll david-driscoll commented May 31, 2020 •
edited
Loading

  • Upgrade to the latest lsp library
  • Added interop support with existing handler endpoints
    • using the namespace o#/
    • eg o#/projects or o#/gotofile
    • This allows consumers to transition to LSP and still use features that exist outside of the lsp spec
    • Events are emitted using the same prefix
  • Fix bug with default logging level

@david-driscoll david-driscoll force-pushed the feature/lsp-commands branch from fbef444 to 697e13f Compare May 31, 2020 03:54
@david-driscoll david-driscoll mentioned this pull request May 31, 2020
Merged
2 tasks
@razzmatazz razzmatazz mentioned this pull request Jul 5, 2020
Closed
@david-driscoll
* Upgrade to the latest lsp library
26e08ce 
* Added interop support with existing handler endpoints
  * using the namespace `o#/`
  * eg `o#/projects` or `o#/gotofile`
  * This allows consumers to transition to LSP and still use features that exist outside of the lsp spec
  * Events are emitted using the same prefix
* Fix bug with default logging level
bjorkstromm
bjorkstromm reviewed Jul 24, 2020
View reviewed changes
Copy link
Member

@bjorkstromm bjorkstromm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome! Nice to finally get some tests so we don't break this all the time.

@david-driscoll david-driscoll marked this pull request as ready for review July 25, 2020 23:12
@filipw
Copy link
Member

filipw commented Jul 27, 2020

ooh I like the CI improvements

filipw
filipw reviewed Jul 27, 2020
View reviewed changes
azure-pipelines.yml Outdated Show resolved Hide resolved
filipw
filipw approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, I jusyt left some small comments.
however, the formatting changes make it difficult to see what is really new and what is not 😛

@david-driscoll
Copy link
Member Author

I will attempt to correct some of the formatting, I have muscle memory and use ctrl+k,d very regularly 🤕

@david-driscoll
Copy link
Member Author

I've updated some of the formatting changes.

@filipw
Copy link
Member

filipw commented Jul 28, 2020 •
edited
Loading

@david-driscoll it might be good to extract the build improvements out of this PR into a separate one - we'd benefit from them immediately, while it might still take a while to get this full LSP upgrade featureset to be merged, what do you think?

if not I'd say we should merge this already unless you are waiting for feedback from PS team

@david-driscoll
Copy link
Member Author

No feedback needed from the PS team, I just wanted to make sure you guys had seen it.

Unless there are other changes this one is good to go in my opinion.

@david-driscoll
Copy link
Member Author

Oh... I noticed the PR comment, that was from a while ago. The powershell team has been using the latest version for a while now!

@filipw
Copy link
Member

filipw commented Jul 28, 2020

ok perfect good to go then 👏

@bjorkstromm
Copy link
Member

Yay!

@david-driscoll david-driscoll merged commit 28eab6e into master Jul 28, 2020
@david-driscoll david-driscoll deleted the feature/lsp-commands branch July 28, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjorkstromm bjorkstromm bjorkstromm approved these changes

@filipw filipw filipw approved these changes

@JoeRobich JoeRobich Awaiting requested review from JoeRobich

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@david-driscoll @filipw @bjorkstromm