-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master to demo/net50 #2153
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JoeRobich
commented
May 14, 2021
•
edited
Loading
edited
- Bumping the Packages.props NuGet version higher than 5.2.0 breaks compatibility with the .NET Core 2.1 SDK. If user have the SDK version set to 2.1.x by a global.json, they will need to move to update it to a more recent SDK. .NET Core 2.1 is end of support August 21, 2021 (see Support Policy).
- Add NET 5.0 Tests CI without Cake tests
- Use Microsoft.Build.Locator for finding VS, DevConsole, and SDK instance of MSBuild
- For .NET 5.0 O# load MSBuild from SDK
fixed CS8605 "Unboxing possibly null value"
Add sentinel file to MSBuild to enable workload resolver
updated to IL Spy 7.0.0.6372
Updated to latest .NET SDKs
Support Solution filter (.slnf)
added workflow_dispatch to GH Actions
Do not return null responses from BlockStructureService and CodeStructureService
This is a port of dotnet/roslyn#53166. There's a bigger question here about how to reuse this code better, but this caused a bunch of confusion while debugging an issue.
Update build tools to match .NET 6 Preview 3 SDK.
Only subscribe to AppDomain.AssemblyResolve once
Add async completion support
JoeRobich
force-pushed
the
merge-master-to-demo-net50
branch
from
May 14, 2021 01:16
0d4b90d
to
61298ff
Compare
JoeRobich
force-pushed
the
merge-master-to-demo-net50
branch
from
May 14, 2021 02:10
7dfe3f3
to
6dad014
Compare
JoeRobich
force-pushed
the
merge-master-to-demo-net50
branch
from
May 16, 2021 05:34
84c5ac4
to
84c3a47
Compare
filipw
approved these changes
May 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic, thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.