Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to demo/net50 #2153

Merged
merged 108 commits into from
May 17, 2021
Merged

Merge master to demo/net50 #2153

merged 108 commits into from
May 17, 2021

Conversation

JoeRobich
Copy link
Member

@JoeRobich JoeRobich commented May 14, 2021

  • Bumping the Packages.props NuGet version higher than 5.2.0 breaks compatibility with the .NET Core 2.1 SDK. If user have the SDK version set to 2.1.x by a global.json, they will need to move to update it to a more recent SDK. .NET Core 2.1 is end of support August 21, 2021 (see Support Policy).
  • Add NET 5.0 Tests CI without Cake tests
  • Use Microsoft.Build.Locator for finding VS, DevConsole, and SDK instance of MSBuild
  • For .NET 5.0 O# load MSBuild from SDK

jcs090218 and others added 30 commits February 28, 2021 01:38
fixed CS8605 "Unboxing possibly null value"
Add sentinel file to MSBuild to enable workload resolver
added workflow_dispatch to GH Actions
@JoeRobich JoeRobich force-pushed the merge-master-to-demo-net50 branch from 0d4b90d to 61298ff Compare May 14, 2021 01:16
@JoeRobich JoeRobich force-pushed the merge-master-to-demo-net50 branch from 7dfe3f3 to 6dad014 Compare May 14, 2021 02:10
@JoeRobich JoeRobich force-pushed the merge-master-to-demo-net50 branch from 84c5ac4 to 84c3a47 Compare May 16, 2021 05:34
Copy link
Member

@filipw filipw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic, thank you

@filipw filipw merged commit d093189 into demo/net50 May 17, 2021
@filipw filipw deleted the merge-master-to-demo-net50 branch May 17, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants