-
Notifications
You must be signed in to change notification settings - Fork 416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Roslyn to 4.2.0-1.22108.11 #2354
Conversation
@@ -7,7 +7,7 @@ | |||
<MicrosoftTestPackageVersion>17.0.0</MicrosoftTestPackageVersion> | |||
<MSBuildPackageVersion>17.0.0</MSBuildPackageVersion> | |||
<NuGetPackageVersion>6.0.0</NuGetPackageVersion> | |||
<RoslynPackageVersion>4.2.0-1.22074.8</RoslynPackageVersion> | |||
<RoslynPackageVersion>4.2.0-1.22108.11</RoslynPackageVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the ExternalAccess libraries are not publish to NuGet there is no 4.2.0-1.final version to reference, instead use the corresponding rolling build.
Looking at the failures, we are blocked on Roslyn adding back some options for completion. See discussion in #2343 (comment). Waiting for dotnet/roslyn#59760 to merge. |
I believe we need to finish this one first: #2343 |
If it's urgent, I can break out the fix from dotnet/roslyn#59760, or better if one of you could review it :) |
@JoeRobich can we revive the upgrade to Roslyn 4.2.0? |
oh... I see now, sorry I missed it! Is it possible that some of the nightlies pulled in has a bad reference to |
Move to the 17.2 Preview 1 release of Roslyn. Includes fix for missing IMoveStaticMembersOptionService dotnet/roslyn@72f98f8
Resolves #2353