Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Roslyn to 4.2.0-1.22108.11 #2354

Closed
wants to merge 2 commits into from

Conversation

JoeRobich
Copy link
Member

Move to the 17.2 Preview 1 release of Roslyn. Includes fix for missing IMoveStaticMembersOptionService dotnet/roslyn@72f98f8

Resolves #2353

@JoeRobich JoeRobich changed the title Update Packages.props Update Roslyn to 4.2.0-1.final Mar 3, 2022
@JoeRobich JoeRobich changed the title Update Roslyn to 4.2.0-1.final Update Roslyn to 4.2.0-1.22108.11 Mar 3, 2022
@@ -7,7 +7,7 @@
<MicrosoftTestPackageVersion>17.0.0</MicrosoftTestPackageVersion>
<MSBuildPackageVersion>17.0.0</MSBuildPackageVersion>
<NuGetPackageVersion>6.0.0</NuGetPackageVersion>
<RoslynPackageVersion>4.2.0-1.22074.8</RoslynPackageVersion>
<RoslynPackageVersion>4.2.0-1.22108.11</RoslynPackageVersion>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the ExternalAccess libraries are not publish to NuGet there is no 4.2.0-1.final version to reference, instead use the corresponding rolling build.

@JoeRobich
Copy link
Member Author

JoeRobich commented Mar 3, 2022

Looking at the failures, we are blocked on Roslyn adding back some options for completion. See discussion in #2343 (comment). Waiting for dotnet/roslyn#59760 to merge.

@tmat
Copy link
Contributor

tmat commented Mar 4, 2022

I believe we need to finish this one first: #2343

@JoeRobich JoeRobich closed this Mar 4, 2022
@genlu
Copy link

genlu commented Mar 4, 2022

If it's urgent, I can break out the fix from dotnet/roslyn#59760, or better if one of you could review it :)

@filipw
Copy link
Member

filipw commented Mar 17, 2022

@JoeRobich can we revive the upgrade to Roslyn 4.2.0?

@JoeRobich
Copy link
Member Author

@filipw In #2343 we moved to 4.2.0-3.22157.8

@filipw
Copy link
Member

filipw commented Mar 17, 2022

oh... I see now, sorry I missed it!

Is it possible that some of the nightlies pulled in has a bad reference to System.Configuration.ConfigurationManager, as described in dotnet/vscode-csharp#5113? I can't seem to be able to pinpoint this

@JoeRobich JoeRobich deleted the update-roslyn-4.2.0-1.final branch May 26, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service of type 'Microsoft.CodeAnalysis.MoveStaticMembers.IMoveStaticMembersOptionsService' is required
4 participants