Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #1180 - Dark mode for trip time picker #1181

Merged

Conversation

amrhossamdev
Copy link
Member

Fixes #1180

Added a custom theme for the dialog to support dark mode.

Screenshot_1710712612 Screenshot_1710712600
  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

@amrhossamdev amrhossamdev changed the title Fixed #1180 - Supported trip time picker dark mode Fixed #1180 - Dark mode for trip time picker Mar 21, 2024
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! I'd love to see a name change on the style but otherwise ready to go.

onebusaway-android/src/main/res/values/themes.xml Outdated Show resolved Hide resolved
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work!

@aaronbrethorst aaronbrethorst merged commit 4191dc4 into OneBusAway:main Mar 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User Reported Bug: Plan Trip Time Picker looks broken in dark mode
2 participants