Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task 705 allowing starring route from route header on map view #1205

Closed
wants to merge 1 commit into from

Conversation

graceschae
Copy link

Implemented partial functionality of the star next to the route header. The star is clickable and the image changes correspondingly, but there is no connection to whether the route is a favorited route or not.
Screenshot 2024-04-25 at 11 48 37 PM
Screenshot 2024-04-25 at 11 48 46 PM

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@aaronbrethorst
Copy link
Member

Hi @graceschae - thanks for opening this up! I look forward to reviewing it once it's ready to go! Just tag me when you're ready for a review.

@amrhossamdev
Copy link
Member

amrhossamdev commented Apr 26, 2024

This PR may help you add functionality to save routes or query them.

You can get all the saved routes and save them on a hash map or something to query faster about if it's starred or not, or you can use content values to check if the route primary key is starred or not.

https://developer.android.com/reference/android/content/ContentValues

if you need any help let me know!

@aaronbrethorst
Copy link
Member

please feel free to reopen once this is complete and ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants