Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App Dependencies Update #1271

Merged
merged 12 commits into from
Oct 21, 2024
Merged

App Dependencies Update #1271

merged 12 commits into from
Oct 21, 2024

Conversation

amrhossamdev
Copy link
Member

@amrhossamdev amrhossamdev commented Oct 18, 2024

Fixes: #1202

Updated all app dependencies

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

Signed-off-by: Amr Hossam <[email protected]>
Signed-off-by: Amr Hossam <[email protected]>
Signed-off-by: Amr Hossam <[email protected]>
Signed-off-by: Amr Hossam <[email protected]>
Signed-off-by: Amr Hossam <[email protected]>
Signed-off-by: Amr Hossam <[email protected]>
Signed-off-by: Amr Hossam <[email protected]>
Signed-off-by: Amr Hossam <[email protected]>
Signed-off-by: Amr Hossam <[email protected]>
@amrhossamdev amrhossamdev self-assigned this Oct 18, 2024
@aaronbrethorst aaronbrethorst marked this pull request as draft October 18, 2024 17:02
@aaronbrethorst aaronbrethorst marked this pull request as ready for review October 18, 2024 17:03
@aaronbrethorst aaronbrethorst marked this pull request as draft October 18, 2024 17:03
@amrhossamdev amrhossamdev marked this pull request as ready for review October 18, 2024 20:54
Copy link
Member

@aaronbrethorst aaronbrethorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! 👍

@aaronbrethorst aaronbrethorst merged commit c1a8709 into main Oct 21, 2024
2 checks passed
@aaronbrethorst aaronbrethorst deleted the dependencies-update branch October 21, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App dependencies need to be updated
2 participants