Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Allow to copy news article into a topic #1711

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Tschuppi81
Copy link
Contributor

Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.

Commit message

:

TYPE: <Feature|Performance|Bugfix>
LINK:
HINT:

Checklist

  • I have performed a self-review of my code
  • I considered adding a reviewer
  • I have added an upgrade hint such as data migration commands to be run
  • I have updated the PO files
  • I have added new modules to the docs
  • I made changes/features for both org and town6
  • I have updated the election_day API docs
  • I have tested my code thoroughly by hand
    • I have tested styling changes/features on different browsers
    • I have tested javascript changes/features on different browsers
    • I have tested database upgrades
    • I have tested sending mails
    • I have tested building the documentation
  • I have added tests for my changes/features
    • I am using freezegun for tests depending on date and times
    • I considered using browser tests für javascript changes/features
    • I have added/updated jest tests for d3rendering (election_day, swissvotes)

Copy link

linear bot commented Feb 28, 2025

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.24%. Comparing base (1ddb434) to head (1cbf848).

Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/org/models/extensions.py 89.74% <100.00%> (+0.04%) ⬆️

... and 184 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ddb434...1cbf848. Read the comment docs.

@Tschuppi81
Copy link
Contributor Author

Tschuppi81 commented Feb 28, 2025

As the test fails I am unsure if my fix broke something. Can you, @cyrillkuettel, comment on it please?

@Tschuppi81 Tschuppi81 removed the request for review from cyrillkuettel March 3, 2025 07:14
@Tschuppi81
Copy link
Contributor Author

@cyrillkuettel The implemented behavior shall not be possible, see comment in ticket. I will rework it to display an info/error instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant