Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix checkbox style #3665

Merged
merged 3 commits into from
Oct 17, 2023
Merged

fix: fix checkbox style #3665

merged 3 commits into from
Oct 17, 2023

Conversation

huhuanming
Copy link
Contributor

No description provided.

@huhuanming huhuanming requested a review from a team as a code owner October 17, 2023 10:27
@what-the-diff
Copy link

what-the-diff bot commented Oct 17, 2023

PR Summary

  • Adjustment to Input Component
    The flex={1} attributed has been added to the Input component. This alteration helps this component to occupy the entire available space when placed within a container that uses flexible box layout, thereby improving the responsiveness and user interface.

  • Changes to TextInput Component
    For the TextInput component, flex={1} was removed, and borderWidth={0} along with borderRightWidth={0} has been added. The elimination of flex allows this component more control over its size irrespective of the container size. Moreover, the added attributes remove the boundary and the right side border of the text input field which ultimately results in a cleaner interface.

  • Removal of CSS Rules
    The CSS rules for button[role="checkbox"]:focus were removed from the main index.css file. This change simplifies the style rules for a focused checkbox, resulting in a more straightforward and cleaner UI design.

@hellohublot hellohublot merged commit 1a7cafe into next Oct 17, 2023
@hellohublot hellohublot deleted the fix/tamagui-version branch October 17, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants