Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change icon name to upperCase for iOS crash #3666

Merged
merged 2 commits into from
Oct 18, 2023
Merged

fix: Change icon name to upperCase for iOS crash #3666

merged 2 commits into from
Oct 18, 2023

Conversation

hellohublot
Copy link
Contributor

No description provided.

@hellohublot hellohublot requested a review from a team as a code owner October 17, 2023 11:18
@what-the-diff
Copy link

what-the-diff bot commented Oct 17, 2023

PR Summary

  • File Name and Import Statements Update
    The file previously named Questionmark.tsx has been renamed to QuestionMark.tsx for clarity and standard coding practices. This change affected both the outline and solid directories under the Icon component. In addition, all import statements that pointed to the old file name now correctly point to the revised QuestionMark.tsx.

  • Export Statement Modification
    The exports in the index files under both the 'outline' and 'solid' directories within the 'Icon' component, which previously exported a component named Questionmark, have been updated. They now export the renamed component QuestionMark, keeping the exports in line with changes to the file and component names.

  • Variable Name and Export Modification
    In the two QuestionMark.tsx files, the component's internal variable name SvgQuestionmark was changed to SvgQuestionMark. This aligns with the component's new naming convention. The export statement in these files was also updated to ensure that the correctly named component, SvgQuestionMark, is exported.

@huhuanming huhuanming enabled auto-merge (squash) October 18, 2023 01:50
@huhuanming huhuanming merged commit c5e3594 into OneKeyHQ:next Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants