-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Disable staking entry #6563
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
WalkthroughThe changes involve modifying the Changes
✨ Finishing Touches
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (1)
packages/shared/types/earn/earnProvider.constants.ts
(1 hunks)
🔇 Additional comments (1)
packages/shared/types/earn/earnProvider.constants.ts (1)
59-61
: Verify impact on token normalization.These tokens are still present in
normalizeToEarnSymbol
. Let's check if any code relies on normalizing these tokens even when staking is disabled.✅ Verification successful
Normalization code is safe but needs cleanup
The normalization of these tokens won't occur because
isSupportStaking
blocks them first. However, you should remove their unused mappings fromnormalizeToEarnSymbol
to maintain clean code.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for usages of normalizeToEarnSymbol with these tokens rg -l "normalizeToEarnSymbol.*('WETH'|'CBBTC'|'WBTC'|'weth'|'cbbtc'|'wbtc')" # Search for direct references to these tokens in earn-related files rg -l "(WETH|CBBTC|WBTC)" --glob "**/*earn*"Length of output: 244
Script:
#!/bin/bash # Check the implementation of normalizeToEarnSymbol and surrounding context rg "normalizeToEarnSymbol" -B 2 -A 10 # View the content of both files to understand token usage echo "=== Content of earn.ts ===" cat packages/shared/types/earn.ts echo -e "\n=== Content of earnProvider.constants.ts ===" cat packages/shared/types/earn/earnProvider.constants.tsLength of output: 8334
Summary by CodeRabbit