revert: Rrevert "fix: ada token decimals (#6592)"

[huhuanming]

This reverts commit c73e3be.

Summary by CodeRabbit

• Bug Fixes
  • Corrected asset transfer amount calculation by using network decimals instead of token-specific decimals
  • Ensures more accurate representation of asset quantities during transaction decoding

[codesandbox]

Review or Edit in CodeSandbox

Open the branch in Web Editor • VS Code • Insiders

Open Preview

[coderabbitai]

Walkthrough

The pull request modifies the buildDecodedTx method in the ADA vault implementation. The change involves shifting decimal places for asset transfer calculations, specifically replacing token-specific decimal shifting with network-level decimal shifting. This adjustment impacts how asset amounts are calculated and represented in decoded transactions for ADA-based transfers.

Changes

File	Change Summary
packages/kit-bg/src/vaults/impls/ada/Vault.ts	Replaced .shiftedBy(-token.decimals) with .shiftedBy(-network.decimals) in transaction decoding logic

Sequence Diagram

sequenceDiagram
    participant Vault
    participant Transaction
    participant Network
    
    Vault->>Transaction: buildDecodedTx()
    Transaction->>Network: Get network decimals
    Network-->>Transaction: Return decimal value
    Transaction->>Transaction: Shift amount using network decimals

Loading

The sequence diagram illustrates how the decimal shifting now occurs using network-level decimal information instead of token-specific decimals during transaction decoding.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c73e3be and 25c022b.

📒 Files selected for processing (1)

• packages/kit-bg/src/vaults/impls/ada/Vault.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: lint (20.x)

🔇 Additional comments (1)

packages/kit-bg/src/vaults/impls/ada/Vault.ts (1)

267-267: Verify token decimal handling across the codebase

Let's check how token decimals are handled in other parts of the codebase.

✅ Verification successful

Decimal shifting implementation is consistent with codebase patterns

The negative decimal shift for display amount conversion follows the standard pattern used across all vault implementations.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for token decimal usage patterns
echo "Searching for token decimal usage..."
rg -A 3 "token.*decimal" 

# Search for shiftedBy operations
echo "Searching for decimal shifting operations..."
rg -A 3 "shiftedBy"

# Search for ADA token-related tests
echo "Searching for ADA token tests..."
rg -A 5 "test.*ada.*token"

Length of output: 69374