Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.1.2 #78

Closed
wants to merge 1 commit into from
Closed

Release 5.1.2 #78

wants to merge 1 commit into from

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Mar 6, 2024

What's Changed

⚠️ Behavior Changes

  • When you call the jsonRepresentation method of OSPushSubscriptionState, if a property is null, the value will now be "" instead of the string literal "nil" #1373

🐛 Bug Fixes & Misc Improvements

  • Rename internal method that was called setSharedInstance to workaround false App Store flagging #1375
  • Improve Swift concurrency safety to address crash reports in production #1376
  • For our server: Add OneSignal-Subscription-Id to Create User request which improves last_active data #1372

This change is Reviewable

@nan-li
Copy link
Contributor Author

nan-li commented Mar 6, 2024

Our released version 5.1.1 causes a build error for users.
This is the same codebase as v5.1.1

@nan-li nan-li requested review from jkasten2 and emawby March 6, 2024 18:05
@nan-li
Copy link
Contributor Author

nan-li commented Mar 6, 2024

5.1.2 also caused the same issues, it was released manually but the problem was not in the release process.

@nan-li nan-li closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant