Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Android Support Dependencies to 28 and Add Xamarin.AndroidX.Migration #232

Merged
merged 2 commits into from
Apr 6, 2021

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented Apr 6, 2021

Issue

Xamarin.AndroidX.Migration requires that all Android Support Library references be the latest Android Support Library version 28 otherwise it won't apply.

Fix

  • Updated all Xamarin.Android.Support.* references to the latest 28.0.0.3 version.
  • Added Xamarin.AndroidX.Migration as a dependency since Google Play requires apps to target 29

Resolves

Tested

Example where upgrading Android Support Dependencies to 28 and adding Xamarin.AndroidX.Migration worked correctly:
https://github.com/jkasten2/Xamarin-AndroidAPI30-OneSignal3.10.4

This change is Reviewable

jkasten2 added 2 commits April 6, 2021 02:09
* This will allow OneSignal to work with projects targeting Android 29+
@jkasten2 jkasten2 requested review from Jeasmine and emawby April 6, 2021 09:22
@jkasten2 jkasten2 changed the title Update android support dependencies to 28 Update Android Support Dependencies to 28 and Add Xamarin.AndroidX.Migration Apr 6, 2021
Copy link
Contributor

@emawby emawby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jkasten2 jkasten2 merged commit a34ea20 into master Apr 6, 2021
@jkasten2 jkasten2 deleted the dependencies/update_android_support branch April 6, 2021 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants