Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Add back missing OneSignalUNUserNotificationCenterSwizzingTest and clean up dead test support files #1089

Merged
merged 2 commits into from
May 19, 2022

Conversation

jkasten2
Copy link
Member

@jkasten2 jkasten2 commented May 19, 2022

Description

One Line Summary

Add back missing OneSignalUNUserNotificationCenterSwizzingTest test file in Xcode and delete some no longer used test support classes.

Details

Motivation

Make sure we don't skip important swizzing tests.

Scope

Just tests affected.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes
  • Tests

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

Sorry, something went wrong.

jkasten2 added 2 commits May 18, 2022 18:47

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
These were not in the xcode project and no code referencing them.
@jkasten2 jkasten2 requested review from nan-li, emawby and a team May 19, 2022 02:19
Copy link
Contributor

@emawby emawby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r1.
Reviewable status: 1 of 5 files reviewed, all discussions resolved (waiting on @nan-li)

@jkasten2 jkasten2 merged commit 8b41a8f into main May 19, 2022
@jkasten2 jkasten2 deleted the test/add_back_to_xcode_proj branch May 19, 2022 17:12
@emawby emawby mentioned this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants