[user model] Fix firing the push subscription observer #1211
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fix bug in firing the push subscription observer, two methods were not correct.
Details
Motivation
calculateIsOptedIn
andcalculateIsEnabled
were not actually using the passed in arguments, and these methods were using the instance variables.Scope
Bug fix for firing push subscription observer.
Testing
Manual testing
Manual testing of push subscription observer behavior:
token
andsubscriptionId
optedIn
flagAffected code checklist
Checklist
Overview
Testing
Final pass
This change is