-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable push notifications for iOS simulators #1244
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our provision detection in OneSignalMobileProvision is not successfully able to find the embedded mobile provision for simulators. This might only affect Xcode managed provisioning profiles. This change is a workaround to that issue to always set testType to 1 since simulators need to receive push in the sandbox environment.
jkasten2
approved these changes
Apr 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @fhboswell)
This was referenced Apr 11, 2023
Closed
Merged
emawby
added a commit
that referenced
this pull request
Aug 10, 2023
Cherry-pick of #1244 Our provision detection in OneSignalMobileProvision is not successfully able to find the embedded mobile provision for simulators. This might only affect Xcode managed provisioning profiles. This change is a workaround to that issue to always set testType to 1 since simulators need to receive push in the sandbox environment.
18 tasks
emawby
added a commit
that referenced
this pull request
Aug 10, 2023
Cherry-pick of #1244 Our provision detection in OneSignalMobileProvision is not successfully able to find the embedded mobile provision for simulators. This might only affect Xcode managed provisioning profiles. This change is a workaround to that issue to always set testType to 1 since simulators need to receive push in the sandbox environment.
nan-li
pushed a commit
that referenced
this pull request
Oct 30, 2023
Cherry-pick of #1244 Our provision detection in OneSignalMobileProvision is not successfully able to find the embedded mobile provision for simulators. This might only affect Xcode managed provisioning profiles. This change is a workaround to that issue to always set testType to 1 since simulators need to receive push in the sandbox environment.
nan-li
pushed a commit
that referenced
this pull request
Oct 30, 2023
Cherry-pick of #1244 Our provision detection in OneSignalMobileProvision is not successfully able to find the embedded mobile provision for simulators. This might only affect Xcode managed provisioning profiles. This change is a workaround to that issue to always set testType to 1 since simulators need to receive push in the sandbox environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Always set test type to 1 for simulators
Details
Our provision detection in OneSignalMobileProvision is not successfully able to find the embedded mobile provision for simulators. This might only affect Xcode managed provisioning profiles.
This change is a workaround to that issue to always set testType to 1 since simulators need to receive push in the sandbox environment.
Motivation
Enable testing push notifications for developers that don't have physical iOS devices.
Scope
iOS push on simulators
Testing
Manual testing
Tested using Xcode 14.3 with iOS 16 simulators
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is