Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.0.0] Preview IAMs #1247

Merged
merged 1 commit into from
Apr 17, 2023
Merged

[5.0.0] Preview IAMs #1247

merged 1 commit into from
Apr 17, 2023

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Apr 11, 2023 •
edited
Loading

Description

One Line Summary

Small PR to add back in preview IAM functionality.

Details

Motivation

It was a TODO to have preview IAMs work again. It uses the Notification Center to send the preview IAM to the Messaging Controller as it lives in another module.

Testing

Manual testing

Tested sending preview IAMs to a physical iPhone 13.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@nan-li
add back in preview IAMs
75518ef 
* Adding back preview IAM functionality
* Use Notification Center to send the preview IAM to the Messaging Controller as it lives in another module
* add Post Notification event name to Common Defines
@nan-li nan-li requested review from emawby and jennantilla April 11, 2023 00:29
@nan-li nan-li requested a review from emawby April 11, 2023 21:53
@nan-li nan-li merged commit 4f05bec into major_release_5.0.0 Apr 17, 2023
@nan-li nan-li deleted the 5.0.0/add_back_preview_iam branch April 17, 2023 18:21
@emawby emawby mentioned this pull request May 1, 2023
Merged
nan-li added a commit that referenced this pull request Oct 30, 2023
@nan-li
Merge pull request #1247 from OneSignal/5.0.0/add_back_preview_iam
9b2eb5b 
[5.0.0] Preview IAMs
nan-li added a commit that referenced this pull request Oct 30, 2023
@nan-li
Merge pull request #1247 from OneSignal/5.0.0/add_back_preview_iam
dba3d25 
[5.0.0] Preview IAMs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emawby emawby emawby approved these changes

@jennantilla jennantilla Awaiting requested review from jennantilla

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nan-li @emawby