Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User model] Fix PushSubscriptionChanged state json representation #1265

Merged
merged 1 commit into from
May 8, 2023

Conversation

emawby
Copy link
Contributor

@emawby emawby commented May 8, 2023

Description

One Line Summary

Use previous/current keys instead of to/from

Details

The jsonRepresentation function of the PushSubscriptionChangedState was still using the old key names instead of previous/current.

Motivation

fix

Scope

PushSubscriptionChangedState (wrappers)

Testing

Manual testing

tested physically

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@emawby emawby changed the base branch from main to major_release_5.0.0 May 8, 2023 18:01
@emawby emawby merged commit 3efece5 into major_release_5.0.0 May 8, 2023
@emawby emawby deleted the user_model/fix_json_representation branch May 8, 2023 18:41
nan-li pushed a commit that referenced this pull request Oct 30, 2023
…ation

[User model] Fix PushSubscriptionChanged state json representation
nan-li pushed a commit that referenced this pull request Oct 30, 2023
…ation

[User model] Fix PushSubscriptionChanged state json representation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants