[5.0.0] Better handling server error responses #1279
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Better, but not yet perfect, handling of error responses for requests including conflicts and deleted users.
Details
Motivation
The SDK can receive many types of error responses to the requests it makes such as when we update a user but find the user has been deleted on the server, etc. We want to handle them gracefully.
Scope
Make
OSResponseStatusType
enum to categorize status codesHandling errors
nil
so that the createUser request will hydrate with a new subscription_id. We still keep the same subscription model whose data is sent in the createUser request.Testing
Manual testing
Tested on iPhone 13 device using iOS 16.5. Sample of scenarios tested:
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is