[3.x.x] Update privacy manifests and add 2 more #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added the 2 existing Privacy Manifests to targets `OneSignalFramework` and `OneSignalExtension` * This is needed for SDK consumers to get the privacy manifests included in their report.
* Apple docs has called out all 4 player model modules in their "SDKs that require a privacy manifest and signature" (https://developer.apple.com/support/third-party-SDK-requirements/) - OneSignal - OneSignalCore - OneSignalExtension - OneSignalOutcomes * Since we are making a change to the other 2 existing manifest files, let's add manifest files for all the frameworks in case we may be required to update the player model SDK again due to them missing from Core and Outcomes
* Apparently `NSPrivacyCollectedDataTypes` needs to be in the privacy manifest for Core even though the framework doesn't use any. * The generated report would say "Missing an expected key: 'NSPrivacyCollectedDataTypes' YourApp.app/Frameworks/OneSignalCore.framework/PrivacyInfo.xcprivacy"
emawby
approved these changes
Mar 25, 2024
This was referenced Mar 25, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Update the 2 existing manifests for
OneSignalFrameworkandOneSignalExtensionas targets, and add 2 more manifests forCoreandOutcomes.Details
Motivation
So SDK consumers can have privacy manifest support as Third-party privacy manifests will be required by Apple.
Previously, they are not added to the other targets of
Core,Outcomesas these targets are already accounted for by inclusion in the umbrellaOneSignalFrameworktarget. App developers do not import these smaller modules directly but only viaOneSignalFramework.However, Apple has called out all 4 player model frameworks under "SDKs that require a privacy manifest and signature" so they may be doing some detection and expect all 4 to have privacy manifests (see https://developer.apple.com/support/third-party-SDK-requirements).
They are added in this PR so we don't have to go back and re-release player model SDKs in case.
OneSignalOutcomes - uses Product Interaction and User Defaults
OneSignalCore - uses User Defaults
Scope
Privacy manifest
Testing
Manual testing
iPhone 13 with ios 17.4
See PDF report generated
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is