Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Release 5.1.6 with new xcframework zips #1422

Merged
merged 1 commit into from
May 1, 2024

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented May 1, 2024

Motivation

  • The zips were previously generated before the xcframeworks were signed so the zips didn't contain code signatures
  • These new ones are generated after the xcframeworks are signed

Only affects SPM
Tested cocoapods still works with release 5.1.6
Tested SPM still works with release 5.1.6 after these changes, and unzipping shows the code signatures

How it was tested:
SPM

Cocoapods

  • Add version 5.1.6 to podfile and install
  • Run the example app

OneSignal/OneSignal-XCFramework#87


This change is Reviewable

* The zips were previously generated before the xcframeworks were signed.
* These are generated after the xcframeworks are signed
@nan-li nan-li merged commit 487247b into main May 1, 2024
4 checks passed
@nan-li nan-li deleted the fix_release_5.1.6_code_signature branch May 1, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants