Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type hints to arguments #140

Closed
iarna opened this issue Apr 24, 2012 · 0 comments
Closed

Add type hints to arguments #140

iarna opened this issue Apr 24, 2012 · 0 comments

Comments

@iarna
Copy link
Contributor

iarna commented Apr 24, 2012

In a number of places we have type hints implied by params phpdoc, but they don't show up in the actual method declaration. Where possible, we should actually put them in. And where PHP's type system is incapable of expressing the argument's type, we should add assertions.
iarna added a commit to iarna/Modyllic that referenced this issue May 3, 2012
@iarna
Add type hints to our methods (OnlineBuddies#140)
8a65dc6
iarna added a commit to iarna/Modyllic that referenced this issue May 3, 2012
@iarna
Add type hints to our methods (OnlineBuddies#140)
124467f
@iarna iarna closed this as completed May 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iarna