Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine RETURNS COLUMN foo assertions #56

Closed
aredridel opened this issue Jan 30, 2012 · 0 comments
Closed

Refine RETURNS COLUMN foo assertions #56

aredridel opened this issue Jan 30, 2012 · 0 comments

Comments

@aredridel
Copy link
Contributor

RETURNS COLUMN foo adds assert('isset($row['foo'])') to the code, but doesn't check that it even got a row back. It should probably return null and not assert in that case
iarna added a commit to iarna/Modyllic that referenced this issue Mar 16, 2012
@iarna
RETURNS COLUMN assertions should allow empty result sets (OnlineBuddi…
c74b7a2 
…es#56)
@iarna iarna mentioned this issue Mar 16, 2012
Merged
aredridel added a commit that referenced this issue Mar 16, 2012
@aredridel
Merge pull request #91 from iarna/returns_column_assert
49fd230 
RETURNS COLUMN assertions should allow empty result sets (#56)
@iarna iarna closed this as completed Oct 1, 2012
iarna added a commit to iarna/Modyllic that referenced this issue Oct 16, 2012
@iarna
Fix column returns on empty sets, for real (OnlineBuddies#56)
acfd290
aredridel added a commit that referenced this issue Oct 16, 2012
@aredridel
Merge pull request #216 from iarna/fix-column-returns
a192bba 
Fix column returns on empty sets, for real (#56)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aredridel @iarna